EdJoPaTo

Results 355 comments of EdJoPaTo

Sorry for not looking into this sooner. The source code here is hard to read and a bit confusing. The variable names are also not that helpful to understand what...

There is also `Buffer::set_span`. There should be a single place to implement this. Either here or there. Then there is a single place to fix a bug instead of multiple...

Another point which is kinda annoying here: There is both a doc comment and a `must_use` comment: ```rs /// This is a fluent setter method which must be chained or...

It should keep a simple message in there. Just pointing to a URL is not very friendly. "The return value contains your object. Read more about it on x" seems...

With the example output: yeah. Nothing or an URL seems like a good enough thing. It’s clear enough that the result is relevant and needs to be used.

A warning having a note: output including warning… not sure if I like that. I understand the reasoning. It explains the warning further. But I think a concept is more...

`#[must_use]` can also be used on a struct directly. Using the [builder-lite-pattern link](https://ratatui.rs/concepts/builder-lite-pattern) doesn't seem to fit well in such a case. For example for `Style` a message like `#[must_use...

> `#[must_use]` can also be used on a struct directly. In some places in can have weird side effects, in others that's really neat. See #1130 for some experiments with...

A theme would be added to a widget before rendering like a border or character set is done. We shouldn’t mix render and widget configuration. Otherwise it’s interesting to explore...