EdJoPaTo
EdJoPaTo
#849 will not be possible with this change.
> I wonder how possible it would be to accept Into for the expected and then make it possible to just pass a bare Iterator / IntoIterator of Into values....
The CI is making code up that is gone with this PR :ghost: https://shouldiblamecaching.com/ https://github.com/ratatui-org/ratatui/actions/runs/8501473392/job/23284430017#step:6:21 Edit: this is why I personally don't use caches on CI… it takes more time...
I like that we are discussing alternatives to improve the usage of this! --- Writing `Buffer::assert_lines` would be fairly simple: ```rs impl Buffer { /// Asserts that this `Buffer` equals...
As there hasn't been a better idea so far… What's the status on this? I would like to see this merged in some way to use the new syntax in...
> It feels odd to me that test code is hanging off the Buffer. > > I think this might feel more appropriate as a standalone function to be imported...
> > [#1007 (comment)](https://github.com/ratatui-org/ratatui/pull/1007#issuecomment-2029975480) > > Perhaps a followup PR for that change is in order - let's get this over the line and I'll slap one together. Just to...
> This only bloats namespaces for users that opt in to using the prelude. Sadly I also code inside of ratatui which makes a lot of use of it… 👻
> > `Buffer::assert_eq(actual, expected)` is possible with this too. > > I think this idea works great. This is already possible. So should I change the usage of it? Keeping...
Looking at the diff of this… not sure I like it as it's less concise afterwards. Basically wants me to have the TestBackend::assert_buffer back because of it being more concise....