Evan Jones

Rebased. Best Evan Jones Website: www.ea-jones.com On Mon, Dec 2, 2024 at 11:26 AM Shane Utt ***@***.***> wrote: > Woops I still owe you a review! If you wouldn't mind...

Changes to the docker-build on main break this branch's docker-build step now. Looks like it's due to the branch name violating docker syntax (can't include '#' in a docker image...

You still can review. I don't recall what I've done since you last reviewed. Maybe the enum variants and the test? On Tue, Dec 3, 2024, 08:31 Shane Utt ***@***.***>...

@shaneutt I addressed all your comments and fixed the docker-build naming issue by switching the workflow to use the PR number instead of branch name since it's guaranteed to comply...

I also strongly the "Rust in 4 Days" course by the google android team: https://google.github.io/comprehensive-rust/ I worked through that (admittedly over more than 4 days) before touching anything in this...

@shaneutt Happy new year 🥳 Is there any other validation we _should_ perform prior to acceptance? I ask because in the [docs](https://gateway-api.sigs.k8s.io/api-types/gatewayclass/) there's an example of a failed acceptance state,...

Okay, I'll look at number 2 as the golden spec. Thanks.

Flynn: > The failure states are dependent upon the implementation. For example, if linkerd sees a route where you have broken some linkerd rule (bad annotation, backendref pointing to something...

You'll have to ask Flynn. This bubbled up in our conversation and I wanted to capture the raw ideas in notes. We didn't flesh out details. Best Evan Jones Website:...

@aryan9600 Still failing 😢  From the logs it looks like the arch might be getting set incorrectly. Do you want it to be aarch64 or x86_64 for CI testing?...