kubernetes-sigs
fix dataplane and udp server builds on arm64
@aryan9600 Still failing 😢
From the logs it looks like the arch might be getting set incorrectly. Do you want it to be aarch64 or x86_64 for CI testing? The latter, correct? Well where is TARGETARCH being set?
Tell that to Flynn ;)
But I agree. arm64 builds are notoriously painful to maintain, in my experience.
Best
Evan Jones Website: www.ea-jones.com
On Fri, Oct 4, 2024 at 11:54 AM Shane Utt @.***> wrote:
@.**** commented on this pull request.
If this isn't going to be super straightforward (I say this because it seems like we've had some issues) then I'm almost inclined to say we should wait until someone else comes along and requests arm64 builds before we spend more time on this?
— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/blixt/pull/261#pullrequestreview-2348896310, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ2T6AMFWZEQOSW7ODWZSXDZZ3QABAVCNFSM6AAAAABK6UAWKGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNBYHA4TMMZRGA . You are receiving this because you were mentioned.Message ID: @.***>
Oh I didn't realize Flynn needed this (the description was empty! there wasn't an issue for it!). I'll go chat with him about it, if this unblocks him then I would be in favor of pressing on actually, as I don't want anyone who's interested in the project to be "locked out" because of their system architecture if we can avoid it within a reasonable amount of effort.
My understanding is @aryan9600 initially hopped on this because Flynn mentioned the build was broken for him. And Sanskar has been chasing llvm versions ever since. We should confirm.
Best
Evan Jones Website: www.ea-jones.com
On Fri, Oct 4, 2024 at 1:58 PM Shane Utt @.***> wrote:
Oh I didn't realize Flynn needed this (the description was empty! there wasn't an issue for it!). I'll go chat with him about it, if this unblocks him then I would be in favor of pressing on actually, as I don't want anyone who's interested in the project to be "locked out" because of their system architecture if we can avoid it within a reasonable amount of effort.
— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/blixt/pull/261#issuecomment-2394577936, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ2T6AJTXE3XBSSK5U3NT6DZZ36PPAVCNFSM6AAAAABK6UAWKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUGU3TOOJTGY . You are receiving this because you were mentioned.Message ID: @.***>
So yeah I talked with Flynn and all his development/testing is done on ARM64 systems so unblocking a community member is a great reason to continue. I did realize however that without the finished Rust control-plane the value of any builds is a bit dubious so just keep that in mind (but otherwise godspeed).
Everything else looks good. Just the build trigger changes and the follow up for runners and then LGTM.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: aryan9600, shaneutt
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [aryan9600,shaneutt]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
