Evgenii Pashkin comments

Results 83 comments of


                                            Evgenii Pashkin

Implement GlyphItemIter manually

Implement iterator and publish only functions on `GlyphItem`

Implement GlyphItemIter manually

Changed constructor visiblity and safety, renamed to `reverse_iter`

Implement GlyphItemIter manually

Replaced `is_reverse` with type parameter

Implement GlyphItemIter manually

@velyan Only one problem still unsolved https://github.com/gtk-rs/pango/pull/161#pullrequestreview-294269572 😢

pango-sys: Drop v1_36_7 feature

Restarting CI

pango-sys: Drop v1_36_7 feature

@ignatenkobrain, @GuillaumeGomez I was careless when checking, it really used in PangoAnalysis for flags. ``` This flag is used to mark runs that hold ellipsized text, in an ellipsized layout....

Make certain structs derive Copy

@qdot, as @jonhoo says types for that `Copy` derived must don't contains pointers. On fast glance I found only 3 of these in gtk-sys: GtkBorder, GtkPageRange, GtkRequisition While I can...

Make certain structs derive Copy

I don't like idea copying classes structure's without using glib-provided functions. Can you show example when it really needed?

gobject_sys::g_signal_handlers_block_matched() unusable?

You can try `G_SIGNAL_MATCH_ID` while `signal_id` acquired by `g_signal_lookup`

gobject_sys::g_signal_handlers_block_matched() unusable?

Or use `glib::signal::signal_handler_block` with `i64` returned by `connect_toggled`