Evgenii Pashkin comments

Results 83 comments of


                                            Evgenii Pashkin

Use a different type to indicate Pango Units

Yes, for all question :wink: As this PR required custom types etc., it will be done after simpler cases, like removing `len` parameters.

Add a way to connect to signals with `after=true`

IMHO currently it not necessary

Add a way to connect to signals with `after=true`

Example please, that we can't cover with bool parameter

Add a way to connect to signals with `after=true`

Seems I don't understand question, as we have flag in ObjectExt::connect https://github.com/gtk-rs/glib/blob/ff2e05f017761c751b13cb92a31a027e6397370d/src/object.rs#L1301

Add a way to connect to signals with `after=true`

You want to add `ButtonExt::connect_clicked_after` ? Always or only on config flag?

Add a way to connect to signals with `after=true`

In public interface I prefer `connect_after_xxx`

Add a way to connect to signals with `after=true`

IMHO changing ObjectExt is not needed

Fix or remove config split_build_rs

@sdroege But now we don't needed build_version.rs so IMHO better rename option

Removing Uninitialized trait?

IMHO we still need it, maybe under other name. Ex. gdk::setting_get, gdk::Rectangle, gdk::RGBA.

Removing Uninitialized trait?

Maybe trait function need be same as `uninit`: `const fn uninit() -> MaybeUninit`