DylanDylann
DylanDylann
[HOLD for payment 2024-12-16] [$250] Web - Header - Approve button appears briefly when it shouldn't
# BugZero Checklist: - [x] **[Contributor]** Classify the bug: Bug classification Source of bug: - [ ] 1a. Result of the original design (eg. a case wasn't considered) - [x]...
I have more context with focus input while working on https://github.com/Expensify/App/pull/51172. Could I take over this issue as C+ if it is external
~@abzokhattab's [proposal](https://github.com/Expensify/App/issues/53136#issuecomment-2501239525) looks good to me. Let's wrap these code only by runAfterInteractions~ ``` setIsSearchRouterDisplayed(true); searchRouterDisplayedRef.current = true; ``` ~🎀 👀 🎀 C+ Reviewed~ Let's me recheck again
@bernhardoj Thanks for your concern. The RCA is the search that opens before the keyboard closes. The selected proposal is to wait for the keyboard to be closed, and then...
> When we open the keyboard in the report screen, the viewport is scrolled. You can log the window.visualViewport.offsetTop to see how much it's scrolled. When we open the search...
> I think the selected solution is not closing the keyboard before going to the search page, but rather having a delay that gives enough time for the keyboard to...
Thanks @bernhardoj But I don't see this problem > but it raises another problem, that is the keyboard won't show when you open the search page.
@abzokhattab With your proposal I see a flicker when opening the search https://github.com/user-attachments/assets/4a09d228-299e-4110-82ef-2bc1b05d81da
@bernhardoj With your proposal, I see an unexpected behavior: 1. Click on main composer 2. Click on Search button 3. Click on Back button 4. See that the keyboard appear...
I only get the flicker when applying your solution