Dustin Ray

> Also if I may criticize your example a little: > > * There is no need to specify the types in the docstring when they are already available in...

> I'm not sure if that's not clear enough or what. We can explicitly document that every function which doesn't end with `*_vartime` is constant time, but I think that...

> Honestly I wasn't even aware that `montgomery_reduction()` is public. I thought the public API is `DynResidue`/`Residue`. Which I always considered to be a confusing name for numbers in Montgomery...

> > I only bring it up because some functions do actually explicitly label themselves as constant time in the documentation, such as add_mod for example: > > "Computes self...

Would something like this format be beneficial? ```rust /// Computes self / rhs, returns the quotient, remainder. /// ### Usage: /// ``` /// use crypto_bigint::{U448, NonZero}; /// /// let a...

> I would argue that this is one of those methods where a usage example is not necessary. The information on how to create a `NonZero` is trivially obtained by...

> @drcapybara I think your example could be OK, however it shouldn't use `unwrap`, but instead something like: `NonZero::new(...).map { |b| a.div_rem(&b) }` [heres a preliminary PR](https://github.com/RustCrypto/crypto-bigint/pull/377) extending this pattern...

# Comparison of deserialization strategies ## Summary During our performance testing and benchmarking of deserialization processes, we observed a consistent minimum of approximately 4.6 million x86 cycles consumed when using...