Whisper icon indicating copy to clipboard operation
Whisper copied to clipboard
verified publisher icon Dun-sin

[FEATURE] Sepreate searching and foundUser into different routes

Open Dun-sin opened this issue 1 year ago • 5 comments

Description

when a user clicks on search, it takes them to the foundUser route immediately instead of staying on the searching route until a chat partner has been found

Screenshots

https://github.com/user-attachments/assets/ad9e3b29-a12c-4647-8435-59fa38b84661

Additional information

You'll find the route definition here https://github.com/Dun-sin/Whisper/blob/dbec99c68f63c606647ea2cef1d458a72ae83b1b/client/src/App.jsx#L50-L57

Dun-sin avatar Aug 18 '24 09:08 Dun-sin

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you.

github-actions[bot] avatar Aug 18 '24 09:08 github-actions[bot]

Hi, can I work on this issue ?

malakbenr avatar Aug 19 '24 14:08 malakbenr

Hi, can I work on this issue ?

Sure, go for it

Dun-sin avatar Aug 19 '24 17:08 Dun-sin

hi @malakbenr you have 2 more days to raise a PR, else you'll be unassigned.

Dun-sin avatar Sep 01 '24 09:09 Dun-sin

@Dun-sin Hi, can I work on this issue ?

VijeshVS avatar Oct 23 '24 06:10 VijeshVS

Hi @Dun-sin , Can I pick this item?

ayushmaz avatar Nov 09 '24 16:11 ayushmaz

Hi @Dun-sin , Can I pick this item?

Sure @ayushmaz, thanks for wanting to contribute. Make sure to read the issue description carefully and ask if you have questions. Follow the rules here, or your PR won't be accepted and will be closed. Good luck!

Dun-sin avatar Nov 09 '24 16:11 Dun-sin