StéphaneDucasse

Results 622 issues of StéphaneDucasse

In SpWindowPresenter we have these three methods. ``` SpWindowPresenter>> openWithLayout: aSpecLayout self buildWithSpecLayout: aSpecLayout. self application registerWindow: self. self withAdapterDo: [ :anAdapter | anAdapter openWithDeferredAction: [ self allPresenters do: [...

windowIsOpened looks like a testing predicate but this is not ``` windowIsOpened isClosed := false ```

Because it is confusing and old and left for another time

``` UndefinedObject(Object)>>doesNotUnderstand: #build [ | concreteMenuPresenter | concreteMenuPresenter := menuPresenter value. concreteMenuPresenter isMorph ifTrue: [ concreteMenuPresenter ] ifFalse: [ concreteMenuPresenter build ] ] in SpMorphicListDataSource>>menuColumn:row: in Block: [ ... [...

``` executeSaveFileDialog: aFileDialog | dialog | dialog := self newFileDialogFor: aFileDialog. dialog answerSaveFile. ^ dialog openModal answer ifNotNil: [ :aString | aString asFileReference ] ``` may be this is dead...

``` rowMorphFor: aNode | node rowMorph | node := aNode nodeModel. rowMorph := self rowMorphGetSelector ifNil: [node rowMorphForColumn: self] ifNotNil: [self rowMorphGetterBlock value: node value: self container]. rowMorph := rowMorph...

Hi esteban I have several questions: - why this class is not packaged in NewTools? - Should not be named StBrowser - What about SpToolCommand? - then Can we define...

- We should fix them - write a test that execute them all and make sure it passes.

papercut

Hi esteban After our discussion on tool registration, I'm fixing all of them. Now I found this method and I do not see how I can fix it. ``` Spotter...