Spec
Spec copied to clipboard
Deprecate openWith:
In SpWindowPresenter we have these three methods.
SpWindowPresenter>> openWithLayout: aSpecLayout
self buildWithSpecLayout: aSpecLayout.
self application registerWindow: self.
self withAdapterDo: [ :anAdapter |
anAdapter openWithDeferredAction: [
self allPresenters do: [ :each | each announceDisplayed ].
self updateTitle ] ]
SpWindowPresenter>>openWith: aSpecLayout
self openWithLayout: aSpecLayout
SpWindowPresenter>> open
self openWith: self presenter layout
I would like to deprecate either openWithLayout: or openWith:
Please tell me. Else I will pick one randomly.
I would deprecate openWith: because:
-
openWithLayout:expresses intent better -
openWith:delegates toopenWithLayout: - Consistency: there are also methods
openDialogWithLayout:andopenModalWithLayout: