Spec icon indicating copy to clipboard operation
Spec copied to clipboard

Deprecate openWith:

Open Ducasse opened this issue 1 year ago • 1 comments

In SpWindowPresenter we have these three methods.

SpWindowPresenter>> openWithLayout: aSpecLayout

	self buildWithSpecLayout: aSpecLayout.
	self application registerWindow: self.
	self withAdapterDo: [ :anAdapter | 
		anAdapter openWithDeferredAction: [ 
			self allPresenters do: [ :each | each announceDisplayed ].
			self updateTitle ] ]

SpWindowPresenter>>openWith: aSpecLayout

	self openWithLayout: aSpecLayout

SpWindowPresenter>> open

	self openWith: self presenter layout

I would like to deprecate either openWithLayout: or openWith:

Please tell me. Else I will pick one randomly.

Ducasse avatar Feb 17 '25 14:02 Ducasse

I would deprecate openWith: because:

  • openWithLayout: expresses intent better
  • openWith: delegates to openWithLayout:
  • Consistency: there are also methods openDialogWithLayout: and openModalWithLayout:

koendehondt avatar Feb 28 '25 13:02 koendehondt