StéphaneDucasse

Results 1102 comments of StéphaneDucasse

The following ``` refactoring failedApplicabilityPreconditions ifNotEmpty: [ ^ self inform: 'The shared variable does not exist' ]. ``` Does not make sense in the `RePushDownMethodDriver` ``` RePushDownMethodDriver >> configureAndRunRefactoring self...

The refactoring precondition is too weak. ``` breakingChangePreconditions "Check that that none of the subclasses of `class` is doing a supercall to any of the selectors that will be pushed...

@balsa-sarenac What do you think about this one.

In the old version (Pharo 10) of the refactoring we got ``` preconditions | condition | condition := selectors inject: self emptyCondition into: [ :cond :each | cond & (RBCondition...

Thanks balsa! @AlexisCnockaert will write some tests and fix it.

@balsa-sarenac what do you think?

Then people can package them in their own private package. Else they can just use Date readFromString:. This is as simple as this.

To make it work for implementors and senders (we are missing references to). I did the following changes ``` "protocol: #'*Calypso-SystemTools-QueryBrowser'" ClyBrowserMorph >> browseSendersOf: aSymbol StMessageBrowser browseSendersOf: aSymbol. "self spawnQueryBrowserOn:...

``` "protocol: #'*Calypso-SystemTools-QueryBrowser'" ``` ClyTextEditor >> implementorsOf: selectedSelector StMessageBrowser browseImplementorsOf: selectedSelector. "self browser browseImplementorsOf: selectedSelector inNameResolver: self browserTool selectedClassOrMetaClass" ```