StéphaneDucasse comments

Results 1102 comments of


                                            StéphaneDucasse

Is whatToDisplayIn: of any use

I renamed it.

Is whatToDisplayIn: of any use

I did it :)

[Refactorings] Implement Driver for PushDownSharedVariable

Thanks Balsa. I'm thinking that it would be great if you have a list of constraints that the implementation should follow. I could try to turn them into automated rules.

[Refactorings] Implement Driver for PushDownSharedVariable

@carolahp did you see the feedback for balsa?

Fix for Negated condition violators (retry)

There is a failing test ``` testFailure Found undeclared Variables: RBProtectVariableTransformation in: RBProtectVariableTransformationTest>>#testVariableDoesNotExist ReleaseTest(TestAsserter)>>assert:description:resumable: ReleaseTest(TestAsserter)>>assert:description: [ "we compile a second method with the undeclared #undeclaredStubInstVar1 to trigger the code path...

There should not be statements after a return statement. This is a parse error.

The following test is not green so this is plain bad. ``` testReturnShouldBeTheLastStatement | ast | ast := self parserClass parseMethod: 'tmp ^ 42. 33 + 33'. self assert: ast...

There should not be statements after a return statement. This is a parse error.

To me this is a parser error and I do not know when the compiler is actually adding errors.

There should not be statements after a return statement. This is a parse error.

``` parseStatementInto: statementList periodList: periods withAcceptedStatementClosers: aCollectionOfClosers "Parse a statement and store it into the statement list. Parse statements as valid only if they end in one of the accepted...

There should not be statements after a return statement. This is a parse error.

So ``` (statementList notEmpty and: [ statementList last isReturn ]) ifTrue: [ node addWarning: 'Unreachable statement' ]. ``` this should raise an error not a warning.

There should not be statements after a return statement. This is a parse error.

@guillep in Pharo 11 and 10 I got an unreachable notice too.