Danny Sanatar

Results 23 comments of Danny Sanatar

> @Dsanatar Note that this is technically a breaking change since `--persist` will now be rendered as an unknown flag and may break certain user scripts. Yea this is a...

/hold I believes this inadvertently breaks hotplugs for standalone VMIs

/unhold fixed by allowing subresource call to for VMIs only if there is no existing owner VM

> Great to see someone working on this! > > I think a better approach would be to have the VMI [add/removeVolume subresource API ](https://github.com/Dsanatar/kubevirt/blob/ephemeral-hotplug-reporting/pkg/virt-api/rest/volumes.go#L53-L61) add/remove a label on the...

> > > Great to see someone working on this! > > > I think a better approach would be to have the VMI [add/removeVolume subresource API ](https://github.com/Dsanatar/kubevirt/blob/ephemeral-hotplug-reporting/pkg/virt-api/rest/volumes.go#L53-L61) add/remove a...

> @Dsanatar Please add the Jira story to the description. Why cant this be reported by the kubevirt_vm_disk_allocated_size_bytes with a type or volume_mode as "ephemeral" ? Updated the description. I...