William Dreese
William Dreese
Hello, have you made any progress on this issue? I'm interested in giving it a go. @itsaaryan
Hello Mark, I've run into an error with using the package's `txn.WithValue` method with a boolean column, and traced the bug back to the distinction between a boolean and index...
As an aside, I can't seem to bring the coverage back up to 100%, and can't figure out why. I think the snapshot recorder has a bug with the commit...
Hello, Funny enough, this problem doesn't originate from the filtering logic in `WithValue()`, but in the column creation in (referring to your gist link) engine.go line 41. When the returned...
@james-bowers Your approach of loop filtering looks good, and no, you probably shouldn't create a new index on each value in a column. The exception to this is a column...
@kelindar requesting review In particular, I understand that a goal of this library is to remove allocations in the transaction pipeline as much as possible - however, I don't see...
Let me know if there's a certain type of test in mind that I'm missing
Looks like I spoke too soon - the test failure looks adjacent to the issue fixed in your previous PR (#69). I personally run these tests on an Intel MacBook...
Should https://github.com/kelindar/column/blob/ff08c9690e6be8161032fa94a174646ef211dfb9/txn.go#L517 be locked with the owner's main mutex?
@kelindar Hello, I've been thinking about this sorted index & wanted to try a base implementation. By creating a new `SortedIndex` type that internally stores a b-tree (probably google/btree) that...