Dreamstick
Dreamstick
Hi! The Windows test failed in `test_density.py` with a MaybeEncodingError (unrelated to my changes). Could you please trigger a re-run?
@IAlibay Hi, if you get some free time please review this PR and if there are any other changes that you would like please let me know!
@marinegor Thanks for the review! I have applied all your suggested commits (reverting ref.prec in those spots and fixing the 0.01 tolerance). Regarding the other places where I used 1e-3—do...
@marinegor Done! I've reverted the remaining 19 instances of the hardcoded 1e-3 tolerance back to the dynamic ref.prec (or self.prec where appropriate) throughout the file, as requested. Ready for final...
@marinegor Thanks for the final pass! I've accepted and committed all your latest suggestions and fixed all the remaining logic/precision details. The code is now exactly as you've requested. I'd...
Sorry for the miscommunication from my side. I confirmed all 22 core tests are green, and the only failure is on the Labeler job, I think we're good to go.
Hey @atharva-2001, I managed to fix the local dependency issues! The tests run locally now without crashing. They are currently skipping because I don't have the full atomic dataset downloaded...