Simon O'Kane

Circumference divided by area, i.e. 2eps_s/r_p, as opposed to the 3eps_s/r_p for spherical particles

I was actually proposing non-spherical particles as a summer project for an undergraduate student. I mainly just wanted to check it wasn't already being done.

Thanks Tino. My proposed geometry is actually circular (2-D) as opposed to cylindrical, as I'm assuming the thickness of the coin to be negligible. I chose the title "Non-spherical particles"...

The student and I have started coding the cylindrical geometry, but there's the line in the function integral in finite_volume.py corresponding to the normal spherical geometry that's confusing us: out...

So what is the correct formulation? Mathematically, the integral is \int_0^1 4 \pi r^2 \,\mathrm{d}r using LaTeX notation. Does this translate to out = 4 * np.pi * integration_vector @...

What is the integral used for anyway? I ask because we're treating the height of the cylinder as infinitesimally small, but I don't imagine your code will like that...

> @DrSOKane in the OKane2020 and OKane2022 parameter sets, which degradation parameters (SEI/plating) are actually referenced in the papers, and which ones are added as examples only (if any)? I...

> Submodel code looks good to me, but I am now against adding new parameters to existing parameter sets from the literature (e.g. adding lithium plating parameters to Ecker). In...

I decided to just not have a parameter set for the composite plating. We plan to make one in the future, but this is a necessary first step.

Hi Tino, the test is NOT good as it passed even on develop. I changed it so it now uses the `loss of lithium due to loss of active material`...