Dominik Rafacz

Results 18 comments of Dominik Rafacz

I definitely think that is a good idea! Actually, adding some of the options as default values for named parameters was my plan all along. I think I can implement...

@lewinfox I completely agree with your views on including other options as well. Enabling should not be included, all the other options working so far should be included. Max lines...

Additionally, there is one thing I would like to discuss. What to do with naming conventions? Currently we have options names following the pattern: `icecream.*` and words are separated with...

I've opened a PR #15 with the feature implemented. It is a baseline feature, though. I have not implemented any changes to the way options worked so far, as it...

Summing up the whole discussion from #12 , I think about a following solution: - Default value of the option `icecream.max.lines` is `NA`. - Default value of the parameter `max.lines`...

I've made a PR with proof-of-concept. I am open to suggestions and changes

That's simpler, indeed. Although, if I understood your idea correctly, it has two problems. Firstly, it requires peeking function to be inextricably linked to our package. I get it that...

There are two more side-issues related to the topic I would like to discuss: * Should we change naming convention of options from dots to underscores? My opinion is: yes....

I think it is a reasonable idea. I will implement it today, we can remove it when we decide to release 1.0.0

I pushed to the main repo two commits that restore option and deprecates them. What do you think, @lewinfox ? Is this enough, or should we print some information about...