Dominik Lech
Dominik Lech
@swapagarwal What do you think about that?
@lb- Yeah, tests were failing because after adding additional conditions in those `is_shown` methods number of queries increased, so I just adjusted number of queries in tests accordingly.
Alright, this PR solves issue. (tho I will definitely work on it some more, because some test didn't pass). I figured out that [this part of code](https://github.com/wagtail/wagtail/blob/bcb5b2baacbfec5da0c82b96da3b19dbddf70b5a/wagtail/admin/views/generic/multiple_upload.py#L144) is the problem....
After some investigation it turned out tests were failing because something else that I changed, but stuff on that branch is fine, sorry for my misunderstanding. This PR is basically...
@lb- Yeah, you are right, I haven't commited that stuff. It's already on branch and everything seems to be okay.
I also managed to reproduce that issue - when you use default image model, and try to upload the same file you get warning message that looks like this: ...
I think I'll fix it tomorrow (that is, unless there is someone else who wants to pick it up).
I tried to fix that, but `get_image_form()` from `images/forms.py` works really weird. I figured that for some reason just changing `fields` to something like this: ``` from wagtail.images.models import Image...
Thanks for your response @Tijani-Dia! Yeah, I understand what you mean, I tried to solve it myself like this, but when I tried I realized that both `CreateFromUploadedImageView.save_object()` and `CreateFromUploadView.post()`...
@VBBr could you explain in some more details what did you to do make it work? I have very similar issue on my rx570.