DoctorKrolic

Results 79 comments of DoctorKrolic

Discuss usage of properties vs fields

> except where it is meant to be accessible by derived types Yeah, these should stay as `protected` properties, it's a standard practice

Make placement of raw string guide line independent of the space chars used

@CyrusNajmabadi Restart failed pipelines please

Use semantics to check for readonly struct

@sharwell PTAL

Switch Roslyn protocol types to System.Text.Json serialization

Fixes https://github.com/dotnet/roslyn/issues/72867 or at least is related to that issue, if we consider that there are still Newtonsoft-based parts for razor compatibility

Improve parser recovery around nullable types in patterns

@333fred Can I have a review here?

Improve parser recovery around nullable types in patterns

@333fred I noticed that there was a regression of parsing an async simple lambda in a conditional expression after pattern. Need another look from you yo approve the change

Improve parser recovery around nullable types in patterns

@RikkiGibson You self-assigned here, can you please take a look then?

Improve and Un-skip Rename Integration tests

@davidwengier Are the underlying problems resolved here? I keep revisiting this issue from time to time since I still want to add integration tests for renaming component's type parameter as...

Do not mark 2 first `int` parameters of an interpolated string handler constructor as unused

Can I have a review here?

Do not mark 2 first `int` parameters of an interpolated string handler constructor as unused

@CyrusNajmabadi PTAL