DoctorKrolic

Results 70 comments of DoctorKrolic
trafficstars

@jcouv @CyrusNajmabadi @333fred PTAL. Added small tweak to group properties and added tests to verify both properties and fields

@Youssef1313 Well, this is what the CI is for)

> any change to syntax normalizer can affect them Well, the syntax normalizer output isn't a public API, so it may change between even minor versions, right? It isn't a...

Is this PR forgotten? @jcouv Can you please take a look, since you've already signed this off before. Also probably want a look from @CyrusNajmabadi to verify that all behaviour...

I preffer to use GitHub UI since I am already in the browser and it doesn't disable auto-merge

> Is it important to try them one by one, or could we simply mark them all missing in one go? > I guess trying one by one doesn't hurt,...

> I prefer to have consistent/uniform handling for chars, whether they are constants or not. [That is already not the case](https://github.com/dotnet/roslyn/blob/a3f4990c8b23ea796f89741f8c583277060f6b3d/src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_StringConcat.cs#L384-L398) - compiler understands constant chars and lowers them to...

@AlekseyTs You missed one of my questions from https://github.com/dotnet/roslyn/pull/71793#issuecomment-1914543738: > > Is it important to try them one by one, or could we simply mark them all missing in one...

Yes, a bunch of work needs to be done here, I'll explicitly request review from you when this is ready

> I think the problem with definition of new well known string members can be observed by adding a unit test like this one, but with `ReadOnlySpan` defined in this...