Kyle Kienapfel

Results 115 comments of Kyle Kienapfel

https://github.com/yuzu-emu/yuzu/blob/5eb30c7827959075cd240f39c6ab57d2c2a8197e/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.cpp#L303-L308 https://github.com/yuzu-emu/yuzu/blob/5eb30c7827959075cd240f39c6ab57d2c2a8197e/src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp#L367-L372 For these two I'm not sure if I should add break, or extra `return nullptr;` statements

in src/core/hle/kernel/k_page_table.cpp there are two cases of R_THROW that I added break statements to. "R_THROW -> R_RETURN -> return" But investigation revealed that the R_THROW macro leads to return, so...

Hi, for review purposes it might be better to do these in a batch instead of one at a time. Personally I'm wondering if breaks are needed when there is...

> Plus I can say that there are not only returns in the switch case I was trying to say that I was curious `switch` statements in situations where the...

I haven't heard back on it. Was hoping to either hear or see improvements. Currently for yuzu-cmd on windows: 1194 ![image](https://user-images.githubusercontent.com/190571/194962111-c25c6a30-5bd7-4b63-9938-b1f4a8a07429.png) yuzu HEAD mainline-636-9611-g01a2ae888 I'd like it to be like...

Looks like 1.9.4 is released, August 15th 2022 https://github.com/lz4/lz4/releases/tag/v1.9.4 Just mentioning so the issue submitter gets a note about it.

I had two fail chapters, and it let me retry them from the "Download Manager". Did they show as fine over there?

development in a development branch instead of using master. interesting to see. https://github.com/absolute-quantum/cats-blender-plugin/blob/c01879183704ce5e3ef0d38352934d1450a6e8bf/tools/atlas.py#L475

Messing with the Hello Kitty style, looks like the "Default Style" is what controls the background, and it does look like the highlight color is merely the background color darkened