Andrew Barna

Results 17 comments of Andrew Barna

@ocefpaf Any thoughts on the "standard_name" attribute stuff? Variable names are low priority, but the values being set in the "standard_name" attribute are not from the CF standard name table.

I got caught by this one yesterday on an M1 machine. I did some digging and found what I think to be the underlying issue. The short explanation is that...

Some additional info for when how to figure out the best way to address this. For the decode using pandas approach, two things I tried worked: using a pandas.array with...

@dcherian We are still using the WOCE QC flags (all three versions of them) so flag masks aren’t something we deal with. Flag masks as I read them, are basically...

@TomNicholas Something different will need to happen with that cast eventually. See #6191 for something that is failing on some systems that users have but is currently unable to be...

Looks like xarray also dropped 3.8 support, we should do the same. Some versions policies: [SPEC0](https://scientific-python.org/specs/spec-0000/), [NEP 29](https://numpy.org/neps/nep-0029-deprecation_policy.html#support-table), Xarray [follows NEP 29 for now](https://docs.xarray.dev/en/stable/getting-started-guide/installing.html#minimum-dependency-versions) but I know they discuss switching...

Nothing jumped out at me reading the changes with my eyes, which is the classic "looks good to me" type response I suppose. I'll poke at the actual code tomorrow...

Awesome, I think this is ready to go in. I guess there hasn't been a black run for a while as the style is slightly changing. And I don't know...

Pre-commit + CI checks for style/black? I've never used isort, but did see when xarray was first adding it, they excluded it from the normal CI checks and just manually...

Should be done. I've never personally used zenodo before...