William Pinaud
William Pinaud
Don't really feel like I broke any test, here. ^^
That's an excellent question, @stof. My understanding so far is that the placeholder should provide a value, hence removing the need for the label attribute. (if I read everything correctly)
Haha I totally forgot about that PR. I just had to re-read it. XD Was just an ultra-low-priority suggestion. I can delete this and do a new one on 6.2,...
> Can you please rebase for 6.2? Done! :) > Also, why not go with `: '--'` on the ternary op inside the tag? That'd make more sense to me....
> Oh yeah, sorry, the first time I opened it the tests were failing for external reasons.
Remaining broken tests (cache & doctrine) seem to have nothing to do with this PR. Not sure I can help with that on that one.
@nicolas-grekas this should be a follow-up to #44464 if I got everything right. :)
> The failures on the `deps=low` job look related. Oh gosh, you're completely right, I went too fast and forgot some tests XD Thanks @xabbuh!
I have a HUGE cache problem with Github... When I look at the tests here it says they're broken, even with force-refresh, no cache in browser, and with I go...
> Please find a PR description that tells me what the PR does. The PR description will be used as a change log entry. Sure, edited the title and description!