DocCon-team

Inconsistency between the code and the doc of IERC1820Registry.setInterfaceImplementer

3

Hi, The doc of the function `IERC1820Registry.setInterfaceImplementer` references a parameter name `interfaceHash`, which is different from the actual parameter name `_interfaceHash`. https://github.com/OpenZeppelin/openzeppelin-contracts/blob/fcf35e5722847f5eadaaee052968a8a54d03622a/contracts/utils/introspection/IERC1820Registry.sol#L61-L70 The function `IERC1820Registry.getInterfaceImplementer` also has the same issue....

Hi, The function `DSToken.transferFrom` emits an event `Transfer`, which is not documented in the README doc. https://github.com/dapphub/ds-token/blob/16f187acc15dd839589be60173ad1ebd0716eb82/src/token.sol#L80 A potential fix could be adding "Emits a `Transfer` event" to the README...

Hi, The function `DSAuth.setOwner` emits an event `LogSetOwner`, which is not documented in the README doc. https://github.com/dapphub/ds-auth/blob/a51e7caa1f03eeffed66d67f3b38605e0f1f881d/src/auth.sol#L42 A potential fix could be adding "Emits a `LogSetOwner` event" to the README...

Hi, The function `DSChiefApprovals.etch` emits an event `Etch`, which is not documented in the README doc. https://github.com/dapphub/ds-chief/blob/4a833cdaeb66313da0fb16108771a52135d23a04/src/chief.sol#L79 A potential fix could be adding the description "Emits an `Etch` event" to...

Hi, In the APIs doc in README.md, it is stated that the functions `DSChiefApprovals.lock` and `DSChiefApprovals.free` fire a `LogLockFree` event. However, their corresponding code does not emit such an event...