Pedro

Results 70 comments of Pedro

> I don't really like shoving all that logic into the packet listener class. Also, this issue applies to all the "crafts" in the game. I feel like we need...

> The `CraftItemEvent` doesn't have a "result" field, so it can't be incorrect. It has a "clicked item" field, and that is correct, you only clicked on a single item...

This merged PR already handle this? https://github.com/PaperMC/Paper/pull/8545

What is the message when are kicked?

okay i think this is related to this patch https://github.com/PaperMC/Paper/blob/d5f1ffc2e6928a6728f91ab2ad2e020b105eab7f/patches/server/0713-Add-packet-limiter-config.patch not sure if is better and another logger (info/warn) for tell in console what is the packet or add this...

Looks good, maybe this change can be included in [server/0939-Fixes-and-additions-to-the-SpawnReason-API.patch](https://github.com/PaperMC/Paper/blob/master/patches/server/0939-Fixes-and-additions-to-the-SpawnReason-API.patch) ?

If im not wrong is the normal behaviour, the hide is mostly for hide visual the entity (because now is hideEntity)

Pretty sure the issue is because that command not send a block/entity who caused the damage and CraftBukkit not expect this then when handle what is the cause use the...

> Can reproduce, falling onto a stalagmite outputs "CONTACT" (as expected) but damage via command outputs "CUSTOM" yeah the currently command only send the damage with not other info like...

This require a rebase but the source branch is master. Please open a new PR using a new branch of source.