Paper
Paper copied to clipboard
PaperMC
Fix warden spawn reason from DEFAULT to NATURAL
Looks good, maybe this change can be included in server/0939-Fixes-and-additions-to-the-SpawnReason-API.patch ?
Natural would imply that the mob was spawned by the natural mob spawning logic, that doesn't look to be the case here
The original issue appears to be WAI outside of the spawn reason shouldn't be default, but, I don't think that it should be "natural" either. There is maybe some wider issue around what all counts towards the limit, the years of butchering to the mob spawning and persistence logic really creates a lot of messes around how mob spawn limits work
Natural would imply that the mob was spawned by the natural mob spawning logic, that doesn't look to be the case here
The original issue appears to be WAI outside of the spawn reason shouldn't be default, but, I don't think that it should be "natural" either. There is maybe some wider issue around what all counts towards the limit, the years of butchering to the mob spawning and persistence logic really creates a lot of messes around how mob spawn limits work
Yeah, I thought so too. But then I saw that there used to be this pull request (https://github.com/PaperMC/Paper/pull/8296) that was closed by the author for no reason. Based on the comments, I assumed that we just take NATURAL now.