DmytroTym
DmytroTym
Potentially closes https://github.com/ZenGo-X/multi-party-ecdsa/issues/148 and https://github.com/ZenGo-X/curv/issues/150.
> What do you mean? Could you give an example? One random example might be `Polynomial`'s [`sample_exact_with_fixed_const_term`](https://github.com/ZenGo-X/curv/blob/master/src/cryptographic_primitives/secret_sharing/polynomial.rs#L120). Its predecessor in `curv` 0.7, `Feldman VSS`'s [`sample_polynomial`](https://github.com/ZenGo-X/curv/blob/v0.7.0/src/cryptographic_primitives/secret_sharing/feldman_vss.rs#L115) method, had a problem: it...
As for scalars getting implicitly copied - in some functions, they are passed by reference and I think it is, if possible, the way to go, right? Any code that...
> Anyway, zeroing stack values very tricky, right It seems so :( Do you think that, as a last resort, something like [this](https://docs.rs/clear_on_drop/0.2.4/clear_on_drop/fn.clear_stack_on_return.html) can be used to just clear the...
@survived would it be OK if we: 1. Check if any reallocations happen (maybe there's a stray vector getting resized somewhere or smth?). If I understand correctly, this is the...
@weikengchen really interesting PR, haven't seen it before. Is it going to get merged? Regardless, I don't think it changes parts of the prover relevant to this PR and the...
Hello everyone! @drewstone I think your error might be a duplicate of https://github.com/ZenGo-X/multi-party-ecdsa/issues/165. At least I was only able to reproduce it when trying to sign with incorrect keys/keys in...
@MatanHamilis could we maybe implement this fix? It's a one-liner, I'll do the PR Also, I could write a better user guide for the demo as at least two people...
@0xYao I believe the fix hasn't been implemented yet. As to the (in)security of gg18: the current ZenGo implementation does not use range proofs for MtA subprotocol which was [shown](https://eprint.iacr.org/2021/1621.pdf)...
Yup, I'll make a PR. Sorry once again.