Dmitry Tsepelev

Results 87 comments of Dmitry Tsepelev

> Curious why you think this will give us false negatives? Often times I put input objects right to the mutation class (cause I'm not going to reuse them anywhere...

We cannot access `ancestors` because we work with AST, not with the instance of `Class` itself 🙂 Rubocop does not even require any dependencies of the code it inspects

@ojab That's because we turn checks on for [everything](https://github.com/DmitryTsepelev/rubocop-graphql/blob/master/config/default.yml#L4) inside any `graphql` folder. I guess in your case it will be enough to just exclude `conrtollers/graphql/**/*`

Hi @ab320012, could you please show me the whole `ProgramApplicationAttributes` class?

I guess the issue is that we should run this cop only for mutations. I'll mark it as bug, but the temporary fix should be something like this added to...

Hi @itay-grudev! May I ask you to add it [here](https://github.com/DmitryTsepelev/rubocop-graphql/blob/master/config/default.yml#L80) and make a PR?

Hi @kiskoza, sounds reasonable, I'll be happy to review this PR!

Hi @scottjg! I've reproduced the issue and investigating, thanks for catching that!

@scottjg here is a possible fix #38957, could you please take a look when you have a moment?