Dmitry Tsepelev

Results 87 comments of Dmitry Tsepelev

Yeah, the approach looks fine! I guess we could add another dummy app (`dummy_rack`?), configure it with brand new `.install_hooks` and add use it for specs instead of `dummy` when...

@djezzzl Looks like the patch is working, but we need to test it somehow. We could try doing something like [this](https://github.com/DmitryTsepelev/ar_lazy_preload/pull/52#issuecomment-881222375)

Technically we need only ActiveRecord, which relies on ActiveSupport and ActiveModel. I guess it should be possible to relax dependencies, PRs are welcome 🙂

Tested locally and and it seems to work! Let's resolve the issue with specs and it will be good to go

@daukadolt Hi, did you have a chance to take a look at it? Anything I can help you with?

tried to rebase, but it still gives me ``` 1) #cache_fragment context caching when keep_in_context is true calls #read once Failure/Error: expect(GraphQL::FragmentCache.cache_store).to have_received(:read).exactly(4) (##"1", "title"=>"object test"}, expires_at=nil>}>).read(*(any args)) expected: 4...

Hi @danielnc! When there is a cache hit, an instance of `GraphQL::Execution::Interpreter::RawValue` is returned to let the execution engine know that we want an early return (heads up: it's not...

> So, fragment cache doesn't halt the field resolution, right? It halts the resolution of all nested fields and returns the value as-is. Looks like policy checks are run against...

That's not an expected behavior, I guess it's just a scenario no one used before. By design, `default_options` are passed to "all cache_fragment calls and cache_fragment: configurations" (see #PR65), namespace...

Hi @RudiBoshoff! That sounds really strange, because gem does reading in a [dead simple way](https://github.com/DmitryTsepelev/graphql-ruby-fragment_cache/blob/1629c5f532b806d600bb8209252a9ff21b0369ba/lib/graphql/fragment_cache/fragment.rb#L51): ```ruby FragmentCache.cache_store.read(cache_key).tap do |cached| return NIL_IN_CACHE if cached.nil? && FragmentCache.cache_store.exist?(cache_key) end ``` In this case...