Markku Post-Uttula

Results 27 comments of Markku Post-Uttula

Whenever You use a temporal component in Your tests (like the "current date/time", which `moment.utc()`-method internally uses) ... You should be prepared to mock the native `Date`-implementation of JavaScript to...

It looks like this PR has been stuck in `Waiting for status to be reported` -state since January. Since I don't feel comfortable adding any unnecessary dummy-commits to retrigger the...

When You want to mock a package such as `Moment` in `Jest` (or any other test library for that matter), You need to implement mock for all the methods the...

The methods like `moment.week()`, etc., are locale-dependent by design. Internally Moment works based on ISO-8601 rules that describe: - the first day of a week is Monday (and the last...

After rereading the original issue report, I have a distinct feeling that I may have (partially) misunderstood the underlying problem. I still believe the problem to be due to the...

> the various JavaScript engines will generally use the locale set in the operating system And after checking the documentation, it turns out that `Moment` doesn't do this. Instead, it...

I did create PR #5972 to add tests demonstrating the issue (and to confirm that the behaviour of `Moment` is indeed "as should be expected". Unfortunately it looks like there...

Of course ... assuming this gets merged, a new release & `npm publish` would also be appreciated :)

`function text(state: {[key: string]: any}, silent: boolean) {` Holeymoley... that looks like TypeScript - can we do that these days? Have I missed something?

Umm... well - you are feeding remarkable HTML instead of Markdown (edit: originally wrote Markup;), so ... I must say I don't see what you're actually expecting to happen?