DirkEilander
DirkEilander
Thanks for the update @hboisgon! Some thoughts/ suggestions: - I'd be nice if we could directly include other filesystems like s3 in this PR - Ideally the specific filesystem packages...
> @DirkEilander or @hboisgon, Mark did a first review, but probably good if one of you also has a look at it, does one of you have time? it is...
left todo: - [ ] update or create new data asset for tests - [ ] create unit tests
@B-Dalmijn: Could you try fixing the failing test (add pyet to test and dev environments in envs folder) and the failing code analysis (workflows/forcing.py#L337 and `reproj_method` argument in `press` function)....
This could be implemented in the loggers of the Model.build and Model.update methods
closing this issue given the different sub issues referred to above.
@JannisHoch Many thanks for the helpful review Jannis! In this comment we provide a first response to your review which I will follow up with a commit to the branch...
Above is a long list with wishes. I think we should start with the following methods: - [ ] setup_vector_data_from_raster. this method should read a rasterdataset; perform user defined zonal...
@hboisgon This small PR is ready for review. It fixes also a hydromt_wflow issue, see linked issue.
@hboisgon I think this one is ready to be reviewed. Could you have a look at it? I don't think it will take long.