Penman

[laurenebouaziz]

[laurenebouaziz]

@DirkEilander or @hboisgon, Mark did a first review, but probably good if one of you also has a look at it, does one of you have time? it is the penman branch in both hydromt and hydromt_wflow. thanks!

[DirkEilander]

@DirkEilander or @hboisgon, Mark did a first review, but probably good if one of you also has a look at it, does one of you have time? it is the penman branch in both hydromt and hydromt_wflow. thanks!

Thanks for the work @laurenebouaziz! I can review the work early next week. Two things to already consider:

• Do we want to make pyeto a required dependency (in which case it should also be included in the pyproject.toml). Or make it optional and only import it when you are actually using it. I saw its a very small library with only native python so in that sense adding it as requirement is not a big issue. On the other hand there is no installation package available which makes me advice against it. We could reach out to them and make an issue about creating a pip and/or conda package.
• It would be really good to add some unit testing! (I can help you set that up)

[laurenebouaziz]

thanks @DirkEilander! For me it is ok if we make it optional. I see that nothing has happened since 2015 in pyeto so I am not sure if issues are still handled. yes let's have a look together at the unit test! (i ran it for Bhutan and it is very very very slow...)

[DirkEilander]

left todo:

• [ ] update or create new data asset for tests
• [ ] create unit tests

[DirkEilander]

@B-Dalmijn: Could you try fixing the failing test (add pyet to test and dev environments in envs folder) and the failing code analysis (workflows/forcing.py#L337 and reproj_method argument in press function). Then I can do a first code review and Laurene later a check on the formula's. Thanks!