Dario Nieuwenhuis

Oops, nice catch. This is not nice, indeed. GATT examples can work without alloc as-is. Alloc is only used for managing l2cap buffers, I have a project where I do...

A related unsolved question is how does the `nrf-softdevice-s1xx` crate versions relate to the softdevice versions...

the softdevices currently in the repo are actually from SDK v17.0.0 https://infocenter.nordicsemi.com/index.jsp?topic=%2Fsdk_nrf5_v17.0.0%2Findex.html (not linked from the tree? why, Nordic?) ``` S112 SoftDevice v7.0.1 (API documentation) S113 SoftDevice v7.0.1 (API documentation)...

Yes, they're under the same Nordic license as the headers. Can't see why not.

You can call the C softdevice `sd_*` functions directly using the `nrf-softdevice-sXX` crates. That should enable porting C code easily. There's no "higher-level" safe wrapper for this functionality in the...

A good starting point would be what the Nordic SDK supports: https://github.com/akiles/nrf5_sdk/blob/master/components/ble/common/ble_advdata.h#L146 https://github.com/akiles/nrf5_sdk/blob/master/components/ble/common/ble_advdata.c#L509 Also, Rubble already has support for this in Rust https://jonas-schievink.github.io/rubble/rubble/link/ad_structure/enum.AdStructure.html For builder pattern vs struct: I'd prefer...

Doing it at runtime is probably fine, that's what the C nrf5-sdk does. Also it makes it possible to make stuff like device names dynamic which is nice. Getting it...

There's no crate for it out there AFAIK. It shouldn't be too hard, mostly: - Add headers for nrf51 softdevices in `/softdevice` (S110, S120, S130) - Generate `nrf-softdevice-sXX` crates for...

Looks good to me overall. Could you add a Cargo feature for MDNS, so that binaries not using it don't get increased code size?

> the read method of the trait will use DMA (not circular) + Idle line detection This doesn't work in practice. Code using the `Read` trait usually assumes that the...