DimitrisJim
DimitrisJim
Reference comment: https://github.com/cosmos/ibc-go/pull/6103#discussion_r1559121898 We should try and not mix and mash pointer-value receivers on methods and instead consistently use one or the other. For types that need mutations and already...
This has already been discussed at some point. We can create an internal folder to contain types that are currently only public due to the organization of packages in a...
Based on these two comments: https://github.com/cosmos/ibc-go/pull/5806#discussion_r1523474395 and https://github.com/cosmos/ibc-go/pull/5806#discussion_r1523478627. Opening to keep track as a point of discussion. Will try to do a minor investigation pre v9 audit to see if...
In the current flow for the 08-wasm tests, [`SetupTest` is invoked once during start-up of a given test](https://github.com/stretchr/testify/blob/3c302f75aec973f1e95cec14224fccb25569936b/suite/suite.go#L138-L192) and once more manually in the loop through the test cases. We...
New version of go appears to be slated for a [February release](https://tip.golang.org/doc/go1.22). Opening issue to keep track of places where this bump should be made: - Each go.mod for all...
These have been marked as deprecated after 02-client refactor [reference ADR](https://github.com/cosmos/ibc-go/blob/main/docs/architecture/adr-026-ibc-client-recovery-mechanisms.md#decision). We could probably remove these in a fully compatible way by using [`reserved`}(https://protobuf.dev/programming-guides/proto3/#reserved) values. Opening issue to keep track...
Currently they are stored after being formatted in a string, resulting in lexicographic ordering when iterating through them. This is slightly counter-intuitive at first and can limit operations that operate...
# Documentation This might be an omission in the docs or a bug in `-m`, not certain. [Documentation](https://docs.python.org/3/using/cmdline.html#cmdoption-i) currently states `-i` used before a script of the `-c` switch launches...
Instead of only running Rust tests, we should also add jobs for running RustPythons (and Ruffs if there's the desire?) tests with every PR. This will result in a larger...
This relates to [a discussion on discord](https://discord.com/channels/1043121930691149845/1044217262225240094/1084150585382670457) a while back. The basic idea is that we can create a custom hash function for our keywords that's based on their structure...