ibc-go icon indicating copy to clipboard operation
ibc-go copied to clipboard

Create an internal package to reduce public API surface

Open DimitrisJim opened this issue 6 months ago • 3 comments

This has already been discussed at some point. We can create an internal folder to contain types that are currently only public due to the organization of packages in a types/keeper flow. Many of the types defined are public solely due to their usage in another sibling package.

We can create an internal package to hold all these types and thereby reduce additions to API which result in more care when changing/updating types.


For Admin Use

  • [x] Not duplicate issue
  • [x] Appropriate labels applied
  • [ ] Appropriate contributors tagged/assigned

DimitrisJim avatar Jan 26 '24 06:01 DimitrisJim

should also be done for 08-wasm and callbacks if necessary

DimitrisJim avatar Jan 30 '24 15:01 DimitrisJim

This was a good change in comet and would be a good one here as well

faddat avatar Jan 31 '24 18:01 faddat

aye, might also be a good idea to do some searching on big projects to get a feel of what is being used similar to what comet did.

DimitrisJim avatar Mar 19 '24 10:03 DimitrisJim