Dimitri Papadopoulos Orfanos

Results 327 comments of Dimitri Papadopoulos Orfanos

I am afraid nsis has many false positives: ```sh $ codespell | wc -l 954 $ ``` Most of them are in translation files that should be skipped. A `.codespellrc`...

All fixes have been merged, thank you. I have added a `.codespellrc` file and fixed the last typos. Do you think it's worth merging?

1. I agree: too much overhead to avoid an error that won't happen any way. I could [ignore rules](https://deepsource.io/docs/setup-analysis#ignore-rules) instead, with `# skipcq: PTC-W0063` and perhaps a human-readable comment. 2....

I think I have addressed all comments. I would rather defer assert fixes to another merge request.

But then how do you make the difference between a broken YAML file and a file that is not a YAML file? This is a linter for YAML files. If...

I could add a test, but is it worth it for this small private method? I mean, this seems hard to test in a higher level test function such as...

Would a unit test of `_get_ticks_matplotlib()` be enough, or do you require a higher level functional test?

I **think** the patch is OK as it is, but I need to double-check the logic - writing a test is definitely required. I do not have a computer with...

I've found location services had been turned off. After turning on location services redshift runs smoothly. It makes sense that redshift needs a location. However instead of exiting with a...

Gnome maps is just an example of an alternative way to handle missing location services. Other than that it is totally unrelated to redshift. I don't know about Ubuntu 14.04,...