Dimitri Papadopoulos Orfanos

Results 835 comments of Dimitri Papadopoulos Orfanos

As a start, I have applied [pyupgrade](https://github.com/asottile/pyupgrade) to the Python code in #203. Once and if this pull request is accepted, I can work on [ruff](https://github.com/charliermarsh/ruff) alerts. If you are...

It would help to be able to reproduce the problem with an actual file. Can you provide one? I believe this is related to the underlying [EDFlib](https://www.teuniz.net/edflib/) library. And indeed...

> The effective sample frequency is: samplefrequency / datarecord duration

Does [EdfReader.getFileDuration](https://pyedflib.readthedocs.io/en/latest/ref/edfreader.html#pyedflib.EdfReader.getFileDuration) help?

Squashed into a single commit.

Thank you for the review, I'll apply the suggestions next week and look into ax_cpu_freq.m4.

> ax_cpu_freq.m4 > ```diff > - [ax_cpu_freq=unknow; rm -f conftest_cpufreq] > + [ax_cpu_freq=unknown; rm -f conftest_cpufreq] > ``` > > Was this one on purpose? > > Is the string...

Actually, you already have such functions: https://github.com/Blosc/c-blosc2/blob/65a1a3034a27004337d23d11f44e529114c65d7d/blosc/blosc-private.h#L136-L150

You even have a similar `endian_handler` function: https://github.com/Blosc/c-blosc2/blob/65a1a3034a27004337d23d11f44e529114c65d7d/blosc/blosc-private.h#L49-L87

I see. How about moving that code to [plugins/plugin_utils.h](https://github.com/Blosc/c-blosc2/blob/main/plugins/plugin_utils.h)?