Dmitry Gashko

Almost usefull but...

4

 I do not think that's correct. Also validation behavior a little bit unexpectable. It's almost what i'm serching for, but...

Modal window closes unexpectedly when 'mousedown' IN the modal and 'mouseup' on the background

7

Here's a video: https://drive.google.com/file/d/150mGwQNYmXyfykiVVdkw1VhCKvBhfQ96/view This is small but really annoying issue! p.s. the easiest solution is replace 'click' event by 'mousedown' (probably)

Just strange line in the source code

1

I've just found one line in the source code that made me confused https://github.com/ghosh/Micromodal/blob/master/lib/src/index.js#L106 ```js const body = document.querySelector('body') ``` Why would you use querySelector to find the body element?...

Particles, router and performance

3

Thanks for this vue plugin. It's helpful, but can you fix memory (and performance) leaks? When it's used in landing page everything is good, but if there's a router... ![Screenshot...

isFunction helper

3

Why do you use [this helper](https://github.com/sha256/Pristine/blob/master/src/utils.js#L24)? ```js export function isFunction(obj) { return !!(obj && obj.constructor && obj.call && obj.apply); } ``` Why not just `typeof func === 'function'`?

Can you add Pristine to http://definitelytyped.org/ (or just add jsdoc comments) ? Because there's no intellisense for Pristine instance now. You know, I mean:   Yea,...

If you implement e11y it's will be so useful. (or at least events like 'onvalid', 'oninvalid')

zIndex for @google/markerclusterer icons is too large

1

 

Type definitions

4

I've just decided to use this cool lib. I found some similar libs and I think this one is better but there's one small point - type definitions. Can you...