DieterDP
DieterDP
Apologies for letting this gather dust. Review comments have been addressed.
> 💔 **-1 overall** > Vote Subsystem Runtime Logfile Comment > +0 🆗 reexec 0m 0s Docker mode activated. > -1 ❌ docker 0m 4s Docker failed to build run-specific...
Rebased on master with additonal javadoc and some renames for clarity.
@ndimiduk @rmdmattingly if you have some spare time. (@hgromer might also be interested)
> @DieterDP-ng any thoughts on this PR? Sorry for the late reply. These changes look OK to me. > This seems alright to me but I'd appreciate to hear from...
I see https://issues.apache.org/jira/browse/HBASE-19441 lists this is fixed in 3.0.0-alpha. So not the 2.x branch? Haven't verified this, if this is the case might be worth to mention. Text looks OK,...
A question (before having had the time to go through your changes): When testing backup functionality for my company, I believe I tested the ability to restore a backup on...
> Did your test also involve moving the backup location? For example, moving the backup from an S3 bucket in us-east-1 to us-east-2 prior to attempting the restore? No, my...
Browsed the code, looks good to me. I now also get why this wasn't an issue for my tests when restoring a backup on a fresh cluster: the backup root...
> @DieterDP-ng I've thought about it a little bit more, and I'm less sure about taking the path out of the BackupManifest. I like that the backups can be used,...