Brian Runnells

Results 28 comments of Brian Runnells

The real problem is that neither `footerTemplate` nor `emptyTemplate` are actually respected in the code. I am definitely open to PRs that rectify this and make the component not show...

@andessen that seems more an implementing detail with typeahead.js. Is there a resource we can link to?

That is a separate issue @andessen that needs to be fixed

I will open a separate issue if this is different from what you are seeing @kitsuneyo, but this addon also breaks in one of our apps in ember 3. [This...

:+1: This worked for getting this addon to work well with a jsonapi-resources backend

Once https://github.com/hashicorp/design-system/pull/2108 lands I'll make similar adjustments here, but for now it'd be good to get more feedback on everything else besides those details

I believe I addressed all the feedback at this point and rebased to pickup the upstream changes to the template registry

I'm going to merge what I have here for now. I'll make a note about the modifier suggestion and add it to a follow-up epic I'm building for this work.