Detze
Detze
The OP is just https://github.com/ppy/osu/issues/11311#issuecomment-1888399637 (map is OD 7, gameplay's Perfect hit window is 17.2 ms, replay's is 17.5 ms due to rounding, rest are all 0.5 ms wider in...
'Sliderfollow still holded' is probably a duplicate of #22150.
'Sliderfollow expand' has been fixed in #27288.
After #27382 the scenario in 'Sliderfollow dissappear on miss' should result in either TailBreak or End, and not Break, so the issue should be resolved.
As noted, currently lazer hit windows are too lenient for standard and taiko, and too strict for mania, compared to stable hit windows. For OD 10 in standard, the OD...
I claimed that based on Walavouchey's investigation with stable reference code, the fact that `Math.Round()` is the method one would normally use to round in C#, and that indeed that's...
Your comment made me think more about the rounding, and its relation to legacy score encoding. The part of the formula in Walavouchey's table responsible for the hit error reads...
Thank you for the review. I've answered all the comments. The reason why I am not changing the default `Contains` formula is twofold: * new rulesets do not want to...
You're right that the equality only makes a difference at the very edge, but when the ranges numbers are the round ones from the stable OD formula, then that edge...
Would making `Contains` `private` and not virtual and using an optional `bool` `is_inclusive` in `HitWindows` constructor to change `Contains` inequality sign resolve your concern? I am merely not a fan...