Derek Stride comments

Results 11 comments of


                                            Derek Stride

Start enforcing parens on macros with arguments

I wanted to weigh in to say that I'm in favour of this change. > I still don't believe the lack of parentheses is costing us a lot of developer...

Start enforcing parens on macros with arguments

@dcopeland I was referring to the PR @gmalette referenced above https://github.com/Shopify/shopify/pull/179085.

Include parser files in Release Assets

That might be possible with a custom release workflow

Trailing Comma - Snowflake

I'm up for adding it! You interested in writing the PR?

Trailing Comma - Snowflake

Adding it to the existing behaviour is good

feat(ci): add workflow to include parser and binary artifacts

> @DerekStride do you have any ideas? I think we have to create a draft release and upload artifacts to that on push to main. Then it'd be a manual...

Feature request: Expose tag from dollar quoted strings

This seems like a good change to me, feel free to take this as guidance not the exact behaviour but I would expect a test like this (`tag` should probably...

Feature request: Expose tag from dollar quoted strings

> The use of quoted_string (rather than dollar_quoted_string) would apply to unwrapping quotes on other quote forms — I don't propose doing that now. Postgresql refers to 'string constants' and...

Errors when embedding Presto inside of Python strings

I do a similar thing but with Ruby e.g. ```ruby sql =

Errors when embedding Presto inside of Python strings

I think you'd have to fork the repo to extend the parser in that way. It's like not too hard, you could just add the curly brace (`{}`) characters to...