Juho Teperi

Results 298 comments of Juho Teperi

Retrieving the latest version number is the easy part, with unpkg or without. With current CI system this could work if we had script that checked compatible packages for version...

I was inspired to implement two scripts, one finding the updated unpkg packages, and second creating commit and branch with the update automatically: https://github.com/cljsjs/packages/commit/b2780c5e87e59d5d5437e858a81fb9554ea94e6b https://github.com/cljsjs/packages/pull/1827 example update for React It...

Using changelog in github message will create references to upstream projects, and mention authors, which will cause unreasonable noise for those people, so something needs to be done about that....

Yes, I was thinking some form in whitelisting packages where this is known to work. For now I'll test this with React and few other packages. And I don't think...

By wrapping changelog text in codeblocks, I think: ``` @metacritical #1827 ``` I already implemented this https://github.com/cljsjs/packages/commit/c55c1ff7b455fff4b289571e89caaa9367b28466

Started investigating this in #547 The implementation is indeed quite simple, as Ratom doesn't itself need to do much, just to register itself to reactive context, and the reactive context...

The code here looks OK. Could be a problem with body params middleware (muuntaja) or the middleware ordering. Check example: https://github.com/metosin/reitit/blob/master/examples/ring-spec-swagger/src/example/server.clj#L92-L109 The middleware order is important. Muuntaja has to read...

Well, you have both Muuntaja format middlewares and wrap-json-params/response. No idea what happens, but it doesn't make much sense as Muuntaja should handle the json requests and responses. Use either...

Now implemented as custom Router, which wraps the parent router. TODO: - [ ] Move to reitit-core - [ ] Migrate reitit-ring to use this. - [ ] Decide on...

I remembered some reason why it might not be necessary or even good idea to move this to core: Frontend and backend have quite a different solutions on what to...