DerEchtePilz
DerEchtePilz
> I'm also unsure what's going on with the command map in unloadCommands... Just so you know, I was talking about the `commands` field.
I think I am gonna close this issue as this is nothing caused by the CommandAPI but rather is caused by the already flawed concept of reloading plugins at runtime.
I split up your command so it's easier to see what's going on and ended with this: ```java new CommandTree("request") .then(new LiteralArgument("toggle") .executesPlayer(info -> { info.sender().sendMessage(Component.text().content("Toggled")); }) ) .then(new MultiLiteralArgument("answer",...
> Oooh, actually, I think this is a very subtle vanilla bug. > > So, usually, literal nodes should take priority over argument nodes. In this case, that means that...
Before I leave the review you requested, here's something I didn't quite understand: If I understood all this correctly, that means that the `(Initatial/Argument)ParseExceptionHandler`s will always intercept the exception thrown...
This latest iteration doesn't work. I tested this command: ```java new CommandAPICommand("test") .withArguments(new ListArgumentBuilder("list") .skipListValidation(true) .withList("test") .withStringMapper() .buildGreedy() ) .executesPlayer(info -> { List list = (List) info.args().get("list"); info.sender().sendMessage(Component.text().content(list.toString()).build()); }) .register();...
Nope, that's not how it's going to work when merged; the List returned has to contain every relevant value. As I said, it would be best to have a separate...
> I'll probably just cancel this PR and wait for `FlagsArgument` proposed by #483 since it likely works better and is more intuitive. I mean, do what you want to...
> Yeah it's not the most intuitive since the list basically is only good for suggestions. Also, not true. The list, if validations are not skipped, provides the player or...
@stumper66 Are you still working on this? If not, it might be better to close this PR since I don't think we want PRs sitting here that are not active...