Jonah Lawrence

Results 141 comments of Jonah Lawrence

It seems to me that some of the data in the .py files is coming from the date_translation_data JSON files and some parts (such as decades) are coming from the...

> The JSON files are not meant to be modified (they come from [http://cldr.unicode.org](http://cldr.unicode.org/)), so this may be not as trivial as I had hoped. I didn't need to modify...

@Gallaecio @noviluni What's the status on this? I don't think I have the time now to try making it locale-based as suggested. I agree that it could be made a...

For the documentation, feel free to contribute alternate ways to self-host if you know of any simple, reliable options. As far as the main deployment, I'll probably end up switching...

It seems like the `AutoModerationTriggerType` enum in `enums.py` was not changed

:+1: It seems like both parts were half done and still 1 part to go. - [x] mention_spam in enum - [x] mention_spam in enum docs - [x] mention_total_limit added...

Should these overloads also include `Optional`? ![image](https://user-images.githubusercontent.com/20955511/193822485-84fb88ad-c3c5-410f-aad4-0193c6329aad.png)

> Instead of defining all comparison methods on `UnknownEnumValue` just define `__lt__` and `__eq__` and add the `functools.total_ordering` decorator on the class. It's less error prone and easier to maintain....

Is `create_followup_message` even called anywhere? I noticed this earlier as well but I don't think it's critical as it seems in these cases (internal http) that all kwargs get passed...

@vantr-o Besides a few lines changed, the typing svg looks pretty similar to my own which is already on the examples list. Maybe you can try customizing it a bit...