Denis Kopylov comments

Results 99 comments of


                                            Denis Kopylov

Set default collation to utf8mb4

Hi @sippsolutions Sorry for delay. I don't see any commits after my message. Unit and Static tests failed on changed file

Set default collation to utf8mb4

Hi @sippsolutions I didn't say about db tests. Only static and unit tests failed for changed file. I believe that some one from core team could help with this fixes...

Set default collation to utf8mb4

@sippsolutions Could you resolve merge conflict?

Fixed typo in tracking.phtml - renamed JS-functions "currier" to "carrier"

@magento run all tests

Fixed typo in tracking.phtml - renamed JS-functions "currier" to "carrier"

@magento run all tests

[View] Removed extra space in link and script tag

@magento run Functional Tests EE, Functional Tests B2B

[View] Removed extra space in link and script tag

I'm not sure that usage of multiple spaces in attributes is a good practice and useful use case

magento/magento2#33980: Using virtual type to configure plugin, interceptor method cannot be generated correctly in setup:di:compile command

@magento run all tests

magento/magento2#33980: Using virtual type to configure plugin, interceptor method cannot be generated correctly in setup:di:compile command

@magento run Unit Tests

Performance improvements

@magento run Database Compare