magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Fixed typo in tracking.phtml - renamed JS-functions "currier" to "carrier"

Open 4ctobias opened this issue 3 years ago • 13 comments

Description (*)

While implementing a custom shipping carrier I mentioned some typos in the JS-handler-functions used in the Magento_Shipping/view/adminhtml/templates/order/tracking.phtml:

  • bindCurrierOnchange
  • currierOnchange

I renamed them to

  • bindCarrierOnchange
  • carrierOnchange

Resolved issues:

  1. [x] resolves magento/magento2#34523: Fixed typo in tracking.phtml - renamed JS-functions "currier" to "carrier"

4ctobias avatar Jul 02 '21 20:07 4ctobias

Hi @4ctobias. Thank you for your contribution Here are some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Jul 02 '21 20:07 m2-assistant[bot]

@magento run all tests

4ctobias avatar Jul 03 '21 09:07 4ctobias

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento create issue

engcom-Alfa avatar Nov 03 '21 14:11 engcom-Alfa

@magento run all tests

ihor-sviziev avatar Apr 07 '22 12:04 ihor-sviziev

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

Den4ik avatar Feb 17 '23 17:02 Den4ik

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run all tests

engcom-Delta avatar Dec 29 '23 12:12 engcom-Delta

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run all tests

Den4ik avatar Dec 29 '23 14:12 Den4ik

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

:heavy_check_mark: QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenario:

  1. Go to app/code/Magento/Shipping/view/adminhtml/templates/order/tracking.phtml
  2. Verify the values in the phtml file.

Before: :heavy_multiplication_x: 

Screenshot 2023-12-31 at 7 42 52 PM

After: :heavy_check_mark:  

Screenshot 2024-01-02 at 11 27 07 AM

Builds are failed. Hence, moving this PR to Extended Testing.

engcom-Delta avatar Jan 02 '24 05:01 engcom-Delta

@magento run all tests

engcom-Echo avatar Jul 16 '24 04:07 engcom-Echo

@magento run all tests

engcom-Echo avatar Jul 16 '24 07:07 engcom-Echo

@magento run Functional Tests EE,Functional Tests CE,Functional Tests B2B

engcom-Echo avatar Jul 16 '24 10:07 engcom-Echo

Functional Tests EE,Functional Tests CE,Functional Tests B2B failure are different on last two run and also contain some known failures.

List of known failures. ACQE-6774 ACQE-6695 ACQE-6331 ACQE-6786 ACQE-6469

Functional Tests B2B Run1 Screenshot 2024-07-16 at 4 16 00 PM

Run2 Screenshot 2024-07-16 at 6 06 46 PM

Functional Tests EE Run1 Screenshot 2024-07-16 at 4 16 21 PM

Run2 Screenshot 2024-07-16 at 6 07 11 PM

Functional Tests CE Run1 Screenshot 2024-07-16 at 4 16 08 PM

Run2 Screenshot 2024-07-16 at 5 45 06 PM

Hence moving it to merge in progress

engcom-Echo avatar Jul 16 '24 12:07 engcom-Echo