Valentin Deleplace

Results 121 comments of Valentin Deleplace

That would be useful indeed. It's mostly about leveraging [Reader.MaxFrameSize](https://github.com/gobwas/ws/blob/master/wsutil/reader.go#L54)

Yes actually MaxFrameSize is not what we want here. LimitedReader is a better candidate.

My thoughts in no specific order: - It's a very good idea to use Context - Let's make sure to not create any global state (not try to enforce globally...

Some related idea: how about a "custom function limiter" returning a function with same signature? With code generation, we're not constrained in genericity and we don't have to deal with...

Generating all Pie functions with `//go:generate pie myType.*` seems to be the best choice in general. My measurements confirm that the final compiled binary is *not* bigger when lots a...

By the way, thank you again for Pie. I really love the project.

When I follow your steps (minus the trailing star at `cp -prf sample/* myproject/`) I do reproduce the crash. I'll have a look at this.

Demoit relies on a hidden folder `.demoit` next to `demoit.html`. `cp -prf sample/* myproject/` does not copy it, while `cp -prf sample myproject` does. I think the root cause is...

@pjlewisuk while having your project folder in demoit's repo root is possible, I suggest to let it live somewhere else in your filesystem. I can think of 2 improvements we...

See possible fix at https://github.com/Deleplace/fork-demoit/commit/adb7af1b18436e217ea1e338ee90fb23aec1a1c4 Can be promoted to a PR, if for strategic reasons we decide to keep 3 distinct ports