Adeola comments

Repositories
Issues
Comments

Results 2 comments of


                                            Adeola

allowedHeadersString will never be null, so this else case will not be entered, this will trigger bug in some cases. please review and fix it.

> allowedMethodString has the same issue allowedMethodString doesn't have an else block.

allowedHeadersString will never be null, so this else case will not be entered, this will trigger bug in some cases. please review and fix it.

> https://github.com/vert-x3/vertx-web/blob/ff42212f74fc55ca73391933a707c2d2de358711/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/CorsHandlerImpl.java#L198 I would like to work on this issue. Can I?